-
Notifications
You must be signed in to change notification settings - Fork 946
fix(generator): show actual env in bit templates output #10152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
When templates specify an env (e.g., `bitdev.react/react-env`), display them grouped under that env instead of the registering aspect. This gives users accurate information about which env their components will use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request fixes the bit templates command output to display component templates grouped under their actual environment (env) instead of the registering aspect. When a component template specifies an env property, the output now shows that env ID, providing users with more accurate information about which environment their components will use.
Changes:
- Modified the
getTemplateDescriptormethod to use the template'senvproperty as theaspectIdwhen available - Added explanatory comments describing the purpose of the change
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Display templates with friendly names (e.g., "React" instead of "teambit.react/react") and show the actual env(s) that will be used (e.g., "env: bitdev.react/react-env"). When a group has templates targeting multiple envs, all envs are shown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- improve env property documentation with expected format - fix grammar: 'components templates' → 'component templates' - improve getFriendlyName to handle kebab-case aspect names
…ference.docs.mdx)
|
Addressing Copilot review comments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Addressing latest Copilot review comments:
|
Summary
When component templates specify an
envproperty,bit templatesnow displays them grouped under that env instead of the registering aspect.Before:
After:
This gives users accurate information about which env their components will actually use, rather than showing the core aspect that registers the templates as a pass-through.